Skip to content

DEPR: revert enforcing the deprecation of exposing blocks in core.internals and deprecate with FutureWarning - #58715

Merged
jorisvandenbossche merged 6 commits into
pandas-dev:mainfrom
natmokval:revert-removing-exposing-blocks-core-internals-replace-DeprecationWarning-FutureWarning
Nov 8, 2024
Merged

jorisvandenbossche merged 6 commits into
pandas-dev:mainfrom
natmokval:revert-removing-exposing-blocks-core-internals-replace-DeprecationWarning-FutureWarning

Conversation

@natmokval

Copy link
Copy Markdown
Member

xref #58467

@natmokval
natmokval marked this pull request as ready for review May 15, 2024 12:13
@natmokval

Copy link
Copy Markdown
Member Author

I reverted the removal of Block and ExtensionBlock from core.internals, and replaced DeprecationWarning with FutureWarning. I think CI failures are unrelated to my changes.

@jorisvandenbossche could you please take a look at my changes? Is that what you meant in your comment in #58467?

@github-actions

Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions Bot added the Stale label Jun 15, 2024
@mroeschke

Copy link
Copy Markdown
Member

Looks like this PR is fairly stale so closing to clear the queue, but happy to reopen at a later time

…osing-blocks-core-internals-replace-DeprecationWarning-FutureWarning
@github-actions

github-actions Bot commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions Bot added the Stale label Nov 8, 2024
@jorisvandenbossche jorisvandenbossche added Internals Related to non-user accessible pandas implementation Deprecate Functionality to remove in pandas and removed Stale labels Nov 8, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 8, 2024
…osing-blocks-core-internals-replace-DeprecationWarning-FutureWarning

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow follow-up, but thanks for the PR @natmokval!

@jorisvandenbossche

Copy link
Copy Markdown
Member

(accidentally added this to the 2.3 milestone instead of 3.0, this change of course does not need to be backported because the related change is only on main)

ZKaoChi pushed a commit to ZKaoChi/pandas that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deprecate Functionality to remove in pandas Internals Related to non-user accessible pandas implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants